Remove redundant ExecutionGraphQlRequest interface declaration #1218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebGraphQlRequest already implements ExecutionGraphQlRequest through its parent class DefaultExecutionGraphQlRequest, making the explicit interface declaration redundant. Signed-off-by: do.vantrinh <do.vantrinh@moneyforward.co.jp>
trinhdvt
force-pushed
the
Remove-redundant-interface-declaration-in-WebGraphQlRequest
branch
from
ceb7446 to
2838b41
Compare
spring-projects-issues
added
the
status: waiting-for-triage
bclozel
added
type: task
rstoyanchev
pushed a commit
that referenced
this pull request
May 29, 2025
WebGraphQlRequest already implements ExecutionGraphQlRequest through its parent class DefaultExecutionGraphQlRequest, making the explicit interface declaration redundant. See gh-1218 Signed-off-by: do.vantrinh <do.vantrinh@moneyforward.co.jp>
|
This is now in with 1f9a21e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removes redundant
implements ExecutionGraphQlRequestfromWebGraphQlRequestclass declaration.Why
WebGraphQlRequestextendsDefaultExecutionGraphQlRequest, which already implementsExecutionGraphQlRequest. The explicit interface declaration was therefore redundant and has been removed to clean up the code.